🚸 Lazy import proxy for lamindb.models
#2849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids using a lamindb model classes class attribute to be used as a default avalue
This proxies all classes and functions from lamindb.models
falexwolf
changed the title
lamindb.modelslamindb.models
|
I think we can close this now with: This was a great way of working around the Django models, but 2851 should ultimately be the simpler solution. If there are problems with 2851, we can come back here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lamins,
In case the default connect to dummy instances is problematic, here's the POC PR for using the lazy import proxy mechanism throughout the lamindb tools.
It requires another PR in laminlabs/lamindb-setup#1064 and laminlabs/bionty#265 (and would need others like wetlab, clinicore, etc... to be updated too)
This replaces #2825